feat: use tomli on Python < 3.15 for TOML 1.1 support#1446
Merged
mkniewallner merged 3 commits intomainfrom Feb 15, 2026
Merged
feat: use tomli on Python < 3.15 for TOML 1.1 support#1446mkniewallner merged 3 commits intomainfrom
tomli on Python < 3.15 for TOML 1.1 support#1446mkniewallner merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
=======================================
+ Coverage 93.4% 93.6% +0.1%
=======================================
Files 38 38
Lines 1036 1034 -2
Branches 103 102 -1
=======================================
Hits 968 968
+ Misses 54 53 -1
+ Partials 14 13 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f7cb04e to
87e568e
Compare
fpgmaas
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
TOML 1.1 was recently released.
tomliadded support for it in 2.4.0, but fortomllibthat is in the standard library, it will only be added in Python 3.15.There are currently debates about the impact on the packaging ecosystem (https://discuss.python.org/t/adopting-toml-1-1/105624), but on our side, since we only read TOML, and don't write anything, there is no reason not to be able to both parse 1.0 and 1.1 IMO.
So this PR requires
tomlion all versions of Python before 3.15. I did not bumptomlilower bound to>=2.4.0because some packages might explicitly opt out fromtomli2.4.0+, so I want to make sure we don't create dependency resolutions issues in some projects.