Add flats to the list (WIP) #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Independent of #1 but works best on top (to get the DIV styling) |
fragglet
reviewed
Aug 31, 2017
texture.js
Outdated
| var lines = wadinfo.split("\n"); | ||
| var i; | ||
| var flats = []; f = null; | ||
| // skip until [flats] |
There was a problem hiding this comment.
I'd suggest just a simple text file containing the list of flats, rather than bother trying to parse wadinfo.txt.
There was a problem hiding this comment.
Certainly easier from the JS side of things but then I/we'd have to generate said text file ourselves... I suppose that's a one-time thing most likely.
There was a problem hiding this comment.
Exactly. ls *.png > flags.txt doesn't seem like a huge amount of effort.
Pretty rough, lots of copy pasta, but a place to work from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty rough, lots of copy pasta, but a place to work from.