Skip to content

Avoid spawning subprocesses on startup to probe graphical capabilities #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyvsmith wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid spawning subprocesses on startup to probe graphical capabilities #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion conf.d/done.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,18 @@ function __done_windows_notification -a title -a message
"
end

function __done_can_get_window_id
# Lightweight capability check using only builtins and env vars.
# Avoids spawning subprocesses on every shell startup (~20ms on macOS).
type -q lsappinfo # macOS
or test -n "$SWAYSOCK" # Sway
or test -n "$HYPRLAND_INSTANCE_SIGNATURE" # Hyprland
or test -n "$NIRI_SOCKET" # Niri
Comment on lines +83 to +85
or begin; test "$XDG_SESSION_DESKTOP" = gnome; and type -q gdbus; end # GNOME
or begin; type -q xprop; and test -n "$DISPLAY"; end # X11
or set -q __done_allow_nongraphical
Comment on lines +82 to +88
end
Comment on lines +79 to +89

function __done_get_focused_window_id
if type -q lsappinfo
lsappinfo info -only bundleID (lsappinfo front | string replace 'ASN:0x0-' '0x') | cut -d '"' -f4
Expand Down Expand Up @@ -197,8 +209,11 @@ function __done_humanize_duration -a milliseconds
end

# verify that the system has graphical capabilities before initializing
# Use lightweight checks (builtins/env vars) instead of spawning subprocesses,
# since this runs on every shell startup. The actual window ID is fetched
# on-demand in __done_started and __done_is_process_window_focused.
if test -z "$SSH_CLIENT" # not over ssh
and count (__done_get_focused_window_id) >/dev/null # is able to get window id
and __done_can_get_window_id
set __done_enabled
end

Expand Down
Loading