fix(demo): use bare tag ids for gauge variableId bindings - #2488
Open
sankalpsthakur wants to merge 1 commit into
Open
fix(demo): use bare tag ids for gauge variableId bindings#2488sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
Demo project bound gauges with Device^~^Tag form that never matches runtime variable map keys (bare tag ids on the wire). Correct all 13 variableId values to bare tag ids so the demo matches the runtime contract (frangoteam#2486).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Demo project used legacy Device^~^Tag variableId form that never matches runtime bare tag ids. Corrected demo bindings to bare tag ids.
Changes
variableIdvalues inclient/src/assets/project.demo.fuxap:Device A^~^Tag Byte→Tag Byte(4 bindings)Device A^~^Tag Bool→Tag Bool(9 bindings)variable/variableSrcandHmiService.toVariableId()unchanged (demo-only, high merge odds).Validation
^~^in demo project (0 remaining)variableIdvalues are bare declared tag ids (Tag Byte,Tag Bool) matchingdevices["Device A"].tagsFixes #2486
AI/LLM disclosure