chore: remove cmake minium version deprecation warning

rickstaa · rickstaa · commit ca0394f6166d · 2024-03-23T21:47:46.000+01:00
This commit ensure that the cmake minimum version < 3.5 deprecation warning is no longer thrown. The minimum cmake version was updated to 3.10 as this is the version that is recommended by the [ROS noetic migration guide](https://wiki.ros.org/noetic/Migration#Increase_required_CMake_version_to_avoid_author_warning). The meta package cmake version has to be kept on 2.8.3 because of some ROS requirements (see https://wiki.ros.org/catkin/package.xml#Metapackages).
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ Requires `libfranka` >= 0.8.0
   * `franka_description`: `<xacro:franka_robot/>` macro now supports to customize the `parent` frame and its `xyz` + `rpy` offset
   * `franka_hw`: Fix the bug where the previous controller is still running after switching the controller. ([#326](https://github.com/frankaemika/franka_ros/issues/326))
   * `franka_gazebo`: Add `set_franka_model_configuration` service.
+  * Update minimum CMake version to 3.10 to remove deprecation warnings
 
 ## 0.10.1 - 2022-09-15
 
diff --git a/franka_control/CMakeLists.txt b/franka_control/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_control)
 
 set(CMAKE_CXX_STANDARD 14)
diff --git a/franka_description/CMakeLists.txt b/franka_description/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_description)
 
 find_package(catkin REQUIRED)
diff --git a/franka_example_controllers/CMakeLists.txt b/franka_example_controllers/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_example_controllers)
 
 set(CMAKE_BUILD_TYPE Release)
diff --git a/franka_gazebo/CMakeLists.txt b/franka_gazebo/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_gazebo)
 
 execute_process(COMMAND uname -m
diff --git a/franka_gripper/CMakeLists.txt b/franka_gripper/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_gripper)
 
 set(CMAKE_CXX_STANDARD 14)
diff --git a/franka_hw/CMakeLists.txt b/franka_hw/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_hw)
 
 set(CMAKE_CXX_STANDARD 14)
diff --git a/franka_msgs/CMakeLists.txt b/franka_msgs/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_msgs)
 
 find_package(catkin REQUIRED COMPONENTS message_generation std_msgs sensor_msgs actionlib_msgs)
diff --git a/franka_ros/CMakeLists.txt b/franka_ros/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.1.3)
+cmake_minimum_required(VERSION 2.8.3)
 project(franka_ros)
 find_package(catkin REQUIRED)
 catkin_metapackage()
diff --git a/franka_visualization/CMakeLists.txt b/franka_visualization/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.10)
 project(franka_visualization)
 
 set(CMAKE_CXX_STANDARD 14)

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-cmake_minimum_required(VERSION 3.4)`
	`1`	`+cmake_minimum_required(VERSION 3.10)`
`2`	`2`	`project(franka_control)`
`3`	`3`
`4`	`4`	`set(CMAKE_CXX_STANDARD 14)`