feat: optional menu-bar extra#118
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Adds an opt-in menu-bar item (Settings → General → "Show Whisky in the menu bar", off by default). When enabled it lets you launch a bottle's pinned programs, reopen Whisky, or quit without the main window focused — and keeps Whisky running after the window is closed so the menu bar stays reachable and Wine processes keep running. When disabled, behaviour is unchanged (no menu bar item, quit on last window close). Closes Whisky-App#571.
33b433a to
6232827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements upstream #571 "Add menu bar."
What
An opt-in menu-bar extra, controlled by a single new setting (Settings → General → "Show Whisky in the menu bar", off by default):
SettingsLink).launchWithUserMode).Design notes
showMenuBarExtradefault:applicationShouldTerminateAfterLastWindowClosedreturnsfalseonly when the menu bar is enabled.WhiskyMenuBarView(WhiskyAppis already at itstype_body_length/file_lengthceiling).Localizable.xcstringsat their sorted positions (translations via Crowdin).Verification
xcodebuild ... -scheme Whisky— BUILD SUCCEEDED.swiftformat --lint .andswiftlint lint --strict— clean.Localizable.xcstringsvalidated as JSON.