Skip to content

Conversation

@evanaze
Copy link

@evanaze evanaze commented Dec 1, 2024

Description

Franken-UI doesn't match UIKit's functionality with text coloring. It's missing the following classes:

  • .uk-text-primary Add this class to emphasize text with the primary color.
  • .uk-text-secondary Add this class to emphasize text with the secondary color.
  • .uk-text-success Add this class to indicate success.
  • .uk-text-warning Add this class to indicate a warning.

Evidence:

From Franken-UI documentation
Screenshot From 2024-12-01 10-09-34

From UIKit documentation
Screenshot From 2024-12-01 10-35-01

Changes in this PR

  1. Adding text primary and secondary colors
  2. Formatting text.ts to match other components files

'.uk-text-muted': {
'@apply text-muted-foreground': {}
},
'.uk-text-primary': {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 51-56 are the only changes in this PR.

@Isaac-Flath
Copy link

Isaac-Flath commented Jan 16, 2025

I use the colors for text and links a lot via tailwind (for example a link might be uk-link text-primary hover:text-primary-focus underline). So having the color options described in this PR built into FrankenUI for both text and links would be useful to me as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants