Skip to content

Conversation

mhdirkse
Copy link
Collaborator

No description provided.

@mhdirkse
Copy link
Collaborator Author

This PR introduces a GitHub Actions workflow that runs the Karma tests. In addition, it fixes the strange behavior of running npm run test. The issue was that this command tried to run the tests of both the playground and the library. It first ran the tests of the library and when you tried to exit that, it started the tests of the playground. The command has been updated to be testPlayground. This way it behaves as expected: when you press Ctrl-C in the calling shell it exits properly. You can also close the opened browser window to speed this up.

@mhdirkse mhdirkse marked this pull request as ready for review March 18, 2025 15:44
Copy link
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add a karma conf file while you could've also added flags to the ng test command?

For example:

{
  "testPlayground": "ng test frank-config-layout-playground --no-watch --browsers=ChromeHeadless"
}

@mhdirkse mhdirkse marked this pull request as draft March 19, 2025 10:33
@mhdirkse mhdirkse marked this pull request as ready for review March 19, 2025 10:38
@mhdirkse
Copy link
Collaborator Author

Ik gebruik npm run ng test .... Dan heb je een extra -- separator nodig om de opties voor npm te scheiden van de opties voor ng. Dat had ik niet door. Nu heb ik inderdaad een oplossing zonder angular.json aan te passen en zonder karma.conf.js te introduceren. Bedankt.

@mhdirkse mhdirkse requested a review from Matthbo March 19, 2025 10:54
@mhdirkse mhdirkse merged commit 7e4710e into master Mar 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants