Skip to content

improve display name for libsecret and gnome keyring #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frankosterfeld merged 1 commit into from
Jan 6, 2026
Merged

improve display name for libsecret and gnome keyring #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions qtkeychain/keychain_unix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,9 +475,16 @@ static void kwalletWritePasswordScheduledStart(const char *service, const char *

void WritePasswordJobPrivate::scheduledStart()
{
auto descr = service;
if (service.isEmpty()) {
descr = key;
} else if (!key.isEmpty()) {
descr = key + "@" + service;
}

switch (getKeyringBackend()) {
case Backend_LibSecretKeyring: {
if (!LibSecretKeyring::writePassword(service, key, service, mode, data, this)) {
if (!LibSecretKeyring::writePassword(descr, key, service, mode, data, this)) {
q->emitFinishedWithError(OtherError, tr("Unknown error"));
}
} break;
Expand All @@ -498,7 +505,7 @@ void WritePasswordJobPrivate::scheduledStart()

QByteArray service = q->service().toUtf8();
if (!GnomeKeyring::store_network_password(
GnomeKeyring::GNOME_KEYRING_DEFAULT, service.constData(),
GnomeKeyring::GNOME_KEYRING_DEFAULT, descr.toUtf8().constData(),
key.toUtf8().constData(), service.constData(), type.toUtf8().constData(),
password.constData(),
reinterpret_cast<GnomeKeyring::OperationDoneCallback>(
Expand Down
Loading