fix: extend last section if have space below

frappe · Sep 17, 2024 · b1bfeca · b1bfeca
1 parent 5e5d475
commit b1bfeca
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 2 deletions.
diff --git a/frontend/src/components/SectionFields.vue b/frontend/src/components/SectionFields.vue
@@ -1,6 +1,7 @@
 <template>
   <FadedScrollableDiv
-    class="flex max-h-[300px] flex-col gap-1.5 overflow-y-auto"
+    class="flex flex-col gap-1.5 overflow-y-auto"
+    :class="[isLastSection ? '' : 'max-h-[300px]']"
   >
     <div
       v-for="field in _fields"
@@ -124,6 +125,10 @@ const props = defineProps({
     type: Object,
     required: true,
   },
+  isLastSection: {
+    type: Boolean,
+    default: false,
+  },
 })
 
 const { getUser } = usersStore()

diff --git a/frontend/src/components/Settings/SidePanelModal.vue b/frontend/src/components/Settings/SidePanelModal.vue
@@ -43,7 +43,11 @@
               :class="{ 'border-b': i !== sections.data.length - 1 }"
             >
               <Section :is-opened="section.opened" :label="section.label">
-                <SectionFields :fields="section.fields" v-model="data" />
+                <SectionFields
+                  :fields="section.fields"
+                  :isLastSection="i == section.data.length - 1"
+                  v-model="data"
+                />
               </Section>
             </div>
           </div>

diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
@@ -161,6 +161,7 @@
               <SectionFields
                 v-if="section.fields"
                 :fields="section.fields"
+                :isLastSection="i == fieldsLayout.data.length - 1"
                 v-model="deal.data"
                 @update="updateField"
               />

diff --git a/frontend/src/pages/Lead.vue b/frontend/src/pages/Lead.vue
@@ -176,6 +176,7 @@
             <Section :is-opened="section.opened" :label="section.label">
               <SectionFields
                 :fields="section.fields"
+                :isLastSection="i == fieldsLayout.data.length - 1"
                 v-model="lead.data"
                 @update="updateField"
               />

diff --git a/frontend/src/pages/MobileDeal.vue b/frontend/src/pages/MobileDeal.vue
@@ -101,6 +101,7 @@
                 <SectionFields
                   v-if="section.fields"
                   :fields="section.fields"
+                  :isLastSection="i == fieldsLayout.data.length - 1"
                   v-model="deal.data"
                   @update="updateField"
                 />

diff --git a/frontend/src/pages/MobileLead.vue b/frontend/src/pages/MobileLead.vue
@@ -77,6 +77,7 @@
               <Section :is-opened="section.opened" :label="section.label">
                 <SectionFields
                   :fields="section.fields"
+                  :isLastSection="i == fieldsLayout.data.length - 1"
                   v-model="lead.data"
                   @update="updateField"
                 />