Skip to content

feat: Implement filter for Facebook lead forms #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sambhusbabu wants to merge 2 commits into
base: develop
Choose a base branch
from
+10 −0
Open

feat: Implement filter for Facebook lead forms #1426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca86175
fest: Implement filter for Facebook lead forms
sambhusbabu Nov 19, 2025
7d95fb1
Update crm/lead_syncing/doctype/lead_sync_source/lead_sync_source.js
sambhusbabu Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crm/lead_syncing/doctype/lead_sync_source/lead_sync_source.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,14 @@ frappe.ui.form.on("Lead Sync Source", {
});
});
},
// added a filter to show form only linked to pages
facebook_page(frm) {
Comment on lines +12 to +13
Copy link
Collaborator

@NagariaHussain NagariaHussain Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an early exit if frm.doc.facebook_page is empty/falsy. What happens when we clear the Facebook page field and then input in the form field?

Copy link
Author

@sambhusbabu sambhusbabu Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix

frm.set_query("facebook_lead_form", function () {
return {
filters: {
"page": frm.doc.facebook_page
}
};
});
},
});