Skip to content

refactor: move payment gateway account doctype out of erpnext and into payments - #54627

Draft
Shllokkk wants to merge 3 commits into
frappe:developfrom
Shllokkk:payment-gateway-fix
Draft

Shllokkk wants to merge 3 commits into
frappe:developfrom
Shllokkk:payment-gateway-fix

Conversation

@Shllokkk

@Shllokkk Shllokkk commented Apr 29, 2026 •

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the skip-release-notes This PR should not be mentioned in the release notes label Apr 29, 2026
@Shllokkk
Shllokkk force-pushed the payment-gateway-fix branch 3 times, most recently from fa3a7ea to cdfbea2 Compare May 10, 2026 19:27
@codecov

codecov Bot commented May 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.37190% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.93%. Comparing base (eba58b2) to head (f09c599).
⚠️ Report is 194 commits behind head on develop.

Files with missing lines Patch % Lines
...ccounts/doctype/payment_request/payment_request.py 53.48% 40 Missing ⚠️
erpnext/setup/utils.py 20.00% 8 Missing ⚠️
erpnext/setup/install.py 20.00% 4 Missing ⚠️
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 0.00% 1 Missing ⚠️
erpnext/accounts/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #54627      +/-   ##
===========================================
+ Coverage    79.83%   79.93%   +0.10%     
===========================================
  Files         1169     1174       +5     
  Lines       128027   129733    +1706     
===========================================
+ Hits        102210   103704    +1494     
- Misses       25817    26029     +212     
Files with missing lines Coverage Δ
...ts/doctype/payment_request/test_payment_request.py 99.31% <100.00%> (+<0.01%) ⬆️
.../doctype/purchase_invoice/test_purchase_invoice.py 97.74% <ø> (ø)
...nts/doctype/subscription_plan/subscription_plan.py 43.18% <ø> (ø)
erpnext/hooks.py 100.00% <100.00%> (ø)
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 74.89% <0.00%> (+0.15%) ⬆️
erpnext/accounts/utils.py 74.29% <0.00%> (+0.08%) ⬆️
erpnext/setup/install.py 18.23% <20.00%> (+0.35%) ⬆️
erpnext/setup/utils.py 70.00% <20.00%> (-4.55%) ⬇️
...ccounts/doctype/payment_request/payment_request.py 70.99% <53.48%> (-1.97%) ⬇️

... and 96 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.37190% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.93%. Comparing base (eba58b2) to head (f09c599).
⚠️ Report is 573 commits behind head on develop.

Files with missing lines Patch % Lines
...ccounts/doctype/payment_request/payment_request.py 53.48% 40 Missing ⚠️
erpnext/setup/utils.py 20.00% 8 Missing ⚠️
erpnext/setup/install.py 20.00% 4 Missing ⚠️
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 0.00% 1 Missing ⚠️
erpnext/accounts/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #54627      +/-   ##
===========================================
+ Coverage    79.83%   79.93%   +0.10%     
===========================================
  Files         1169     1174       +5     
  Lines       128027   129733    +1706     
===========================================
+ Hits        102210   103704    +1494     
- Misses       25817    26029     +212     
Files with missing lines Coverage Δ
...ts/doctype/payment_request/test_payment_request.py 99.31% <100.00%> (+<0.01%) ⬆️
.../doctype/purchase_invoice/test_purchase_invoice.py 97.74% <ø> (ø)
...nts/doctype/subscription_plan/subscription_plan.py 43.18% <ø> (ø)
erpnext/hooks.py 100.00% <100.00%> (ø)
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 74.89% <0.00%> (+0.15%) ⬆️
erpnext/accounts/utils.py 74.29% <0.00%> (+0.08%) ⬆️
erpnext/setup/install.py 18.23% <20.00%> (+0.35%) ⬆️
erpnext/setup/utils.py 70.00% <20.00%> (-4.55%) ⬇️
...ccounts/doctype/payment_request/payment_request.py 70.99% <53.48%> (-1.97%) ⬇️

... and 96 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shllokkk
Shllokkk force-pushed the payment-gateway-fix branch from f09c599 to cace453 Compare June 23, 2026 13:52
@stale

stale Bot commented Jul 9, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale Bot added the inactive label Jul 9, 2026
@Shllokkk
Shllokkk force-pushed the payment-gateway-fix branch from cace453 to f435938 Compare July 11, 2026 14:55
@stale stale Bot removed the inactive label Jul 11, 2026
@Shllokkk
Shllokkk force-pushed the payment-gateway-fix branch from f435938 to 54e4694 Compare July 11, 2026 15:37
@stale

stale Bot commented Jul 27, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale Bot added the inactive label Jul 27, 2026
@stale stale Bot closed this Aug 3, 2026
@Shllokkk Shllokkk reopened this Aug 3, 2026
@stale stale Bot removed the inactive label Aug 3, 2026
@Shllokkk
Shllokkk force-pushed the payment-gateway-fix branch from 04f61c1 to ffc5aae Compare August 13, 2026 19:05
@stale

stale Bot commented Aug 29, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale Bot added the inactive label Aug 29, 2026
@stale stale Bot closed this Sep 5, 2026
@Shllokkk Shllokkk reopened this Sep 8, 2026
@Shllokkk Shllokkk removed the inactive label Sep 8, 2026
@stale

stale Bot commented Sep 26, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale Bot added the inactive label Sep 26, 2026
@Shllokkk Shllokkk removed the inactive label Sep 26, 2026
@stale

stale Bot commented Oct 11, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale Bot added the inactive label Oct 11, 2026
@Shllokkk Shllokkk removed the inactive label Oct 11, 2026
@stale

stale Bot commented Oct 31, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@Shllokkk
Shllokkk force-pushed the payment-gateway-fix branch from b1f62a4 to a02abd2 Compare November 8, 2026 00:06

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accounts skip-release-notes This PR should not be mentioned in the release notes

Projects

None yet

3 participants