Skip to content

fix(accounts): map recalculated Dunning balances (v16) - #65273

Merged
mergify[bot] merged 2 commits into
frappe:version-16-hotfixfrom
aerele:fix/v16-dunning-partial-currency
Nov 10, 2026
Merged

mergify[bot] merged 2 commits into
frappe:version-16-hotfixfrom
aerele:fix/v16-dunning-partial-currency

Conversation

@Pandiyan5273

@Pandiyan5273 Pandiyan5273 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Issue

  • Creating a Dunning for a partially paid foreign-currency Sales Invoice fails because the mapper copies the unchanged Payment Schedule amount while validation uses the recalculated unpaid balance.
  • Backport of fix(accounts): map recalculated balances for Dunning #64585, adapted to the existing v16 Sales Invoice controller.

Closes #64629.

Steps to replicate

  • Use a USD company and enable “Allow multi-currency invoices against single party account” in Accounts Settings.
  • Create a customer with EUR billing currency and no party account, so the receivable account uses USD.
  • Submit an overdue EUR 1,000 Sales Invoice at exchange rate 1.1, without a Payment Terms Template.
  • Submit a Payment Entry allocating USD 550 to the invoice without allocating it to a payment term.
  • Select Create > Dunning on the invoice. The same failure occurs with two installments when payment-term allocation is disabled.

Actual behavior

  • The mapper copies EUR 1,000, but validation permits only the remaining EUR 500 and rejects the Dunning.

Expected behavior

  • Create and submit the Dunning for the remaining EUR 500, retaining only unpaid installments and using their balances for interest calculation.

No-docs

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Queue requested — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

✅ Merged into version-16-hotfix as 790c411 at 08:16 UTC

39 min in the queue, 27 min of it CI.

So far

3 merge conditions met
  • #review-threads-unresolved = 0 · required by GitHub branch protection
  • github-review-approved · required by GitHub branch protection
  • any of:
    • all of:
      • check-success=Patch Test
      • check-success=Python Unit Tests (1)
      • check-success=Python Unit Tests (2)
      • check-success=Python Unit Tests (3)
      • check-success=Python Unit Tests (4)
    • -files~=^(?!erpnext/locale/main\.pot$)

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 10, 2026
@mergify
mergify Bot merged commit 790c411 into frappe:version-16-hotfix Nov 10, 2026
15 of 16 checks passed
@mergify mergify Bot removed the queued label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v16] Create Dunning fails for a partly paid foreign-currency Sales Invoice

1 participant