feat(slider)!: support bidirectional fill#764
Draft
GursheenK wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bidirectional fill
When
minis negative, the slider fill now originates from the zero rather than always from the left edge, making positive and negative values visually distinct. Added docs and test for the same.Fix
SliderRootwas missing an explicit height, so the thumb (size-4/size-5) overflowed the component's bounding box. Addedh-4forsmandh-5formdto match the thumb dimensions so that we no longer need to compensate for the overflow in our own layouts.Breaking change
Sliderroot element now has an explicith-4/h-5Tailwind class. Previously the root had no height class and sized naturally to its content. Consumers who applied a custom height to the Slider container or overrode its height via CSS may see a layout shift.Migration: if your Slider container has a fixed height smaller than
h-4(16px), increase it or remove the constraint.Docs preview: https://ui.frappe.io/pr-preview/pr-764/
Coverage: 56.10% (+0.01% vs
main)