Skip to content

Conversation

@david-loe
Copy link

fixes #1801

@DanielRadlAMR
Copy link
Collaborator

Please update this PR so that all image files share the same defaults

@david-loe
Copy link
Author

the github action to update the erpnext version should also be changed to version 16

@DanielRadlAMR
Copy link
Collaborator

https://github.com/david-loe/frappe_docker/blob/patch-1/images/bench/Dockerfile

Line 130: The Node version should be updated to 24.13.0.

In this Dockerfile, I noticed that multiple Python and Node versions are installed to maintain backward compatibility.

Currently, some of the latest bench images have trouble running Frappe v15. We might want to address this to ensure v15 support.

My suggestion would be to drop v14 compatibility and add v15 instead. We could also rename the Python/Node version arguments to something more generic (e.g., PYTHON_VERSION_PREV / NODE_VERSION_PREV) rather than referencing a specific version.

You missed to update frappe branch in the custom dockerfile.

@DanielRadlAMR
Copy link
Collaborator

Just noticed today is the official EOL of version-14. So dropping compatibility should be fine in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why not defaulting to python 3.14 and node 24 in custom image Dockerfile?

2 participants