fix(a11y): add alt text to images missing it - #549
Open
swe-sanad wants to merge 1 commit into
Open
Conversation
- CoverImage.vue: generic but accurate description (the component has no access to what the cover belongs to). - ImagePreview.vue: same, for the enlarged modal preview. - UnsplashImageBrowser.vue: Unsplash's own alt_description field per photo, falling back to a generic description when a photo has none.
Contributor
Confidence Score: 5/5The accessibility-only changes appear safe to merge. The new attributes match the available image context and preserve existing rendering and selection behavior. Reviews (1): Last reviewed commit: "fix(a11y): add alt text to images missin..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three images had no
altattribute.Fix
CoverImage.vue/ImagePreview.vue: a generic-but-accurate description — neither component has access to what the image is actually a cover/preview of.UnsplashImageBrowser.vue: Unsplash's ownalt_descriptionfield per photo, falling back to a generic description for photos that don't have one.