Option to enable grouping and add multiple tasks to a row - rebase

[stephenjmaher]

I came across #448 and thought the feature would be of value. I have rebased the changes from @iaminamcom to bring it up to date with the current master.

[safwansamsudeen]

Thanks! Can you please add screenshots?

[stephenjmaher]

Do you want screenshots to included in this PR? Or are they for the README?

[stephenjmaher]

Here are what the changes will look like.

[stonesoft-tech]

When will this be merged into the main branch?

[stephenjmaher]

I would like to merge these changes. I am just waiting on approval from someone with write access.

[stonesoft-tech]

Can this be approved so it can be merged?
Please!!!

[stonesoft-tech]

There is an issue with this in Safari...

Gantt won't load when grouping:true

The following error is caught from line 24 of frappe-gantt.umd.js:
s.union is not a function. (In 's.union(new Set(this.tasks.map(a=>a.group)))', 's.union' is undef

Works fine in Chrome and Firefox

[stephenjmaher]

@stonesoft-tech The use of union has been removed. Could you please check this on Safari now?

[stonesoft-tech]

@stonesoft-tech The use of union has been removed. Could you please check this on Safari now?

Sure thing. Will test later tonight. Thanks!

[stonesoft-tech]

@stonesoft-tech The use of union has been removed. Could you please check this on Safari now?

This is working on Safari. Thanks.

It looks like the Scroll to Today is not functioning though in Safari. It scrolls to the beginning of the chart... No errors in the console.

[stephenjmaher]

Do you know if the error with "Scoll to Today" is due to the changes in the MR? I don't know what changes could have been introduced to cause this to stop working.

[stonesoft-tech]

Do you know if the error with "Scoll to Today" is due to the changes in the MR? I don't know what changes could have been introduced to cause this to stop working.

No because it wouldn't load at all before the MR. I will test on the original build (without grouping) and create a new issue.

[calebeaires]

Hey team, will this PR be merged? 😄

[safwansamsudeen]

Hey @calebeaires - I'm not actively working on Gantt right now - when I get back to it (probably next month), I'll review and merge.

[safwansamsudeen]

@stephenjmaher this PR seems to be broken in a couple places (for example, you can't drag or edit anything but the first bar in a group) :(.

[stephenjmaher]

Sorry @safwansamsudeen, It was an error in the example html. The tasks in the same group had the same ID. The example has been updated now.

Were there any other errors that you found?