Skip to content

fix: dark mode regressions#3366

Open
HarishChandran3304 wants to merge 2 commits into
frappe:developfrom
HarishChandran3304:fix/dark-mode-regressions
Open

fix: dark mode regressions#3366
HarishChandran3304 wants to merge 2 commits into
frappe:developfrom
HarishChandran3304:fix/dark-mode-regressions

Conversation

@HarishChandran3304
Copy link
Copy Markdown
Contributor

PR to fix dark mode regression issues mentioned in #3358

Fixes:

  1. Invisible dividers in Settings list views -> bump <hr> to --outline-gray-2 in dark mode only
  2. Mobile sidebar washed the screen near-white -> use bg-black-overlay-500
Screen.Recording.2026-05-18.at.3.10.06.PM.mov

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.06%. Comparing base (ec40d5a) to head (962546b).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3366      +/-   ##
===========================================
- Coverage    59.07%   59.06%   -0.02%     
===========================================
  Files          129      129              
  Lines         6515     6515              
===========================================
- Hits          3849     3848       -1     
- Misses        2666     2667       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RitvikSardana
Copy link
Copy Markdown
Member

image

@HarishChandran3304
Copy link
Copy Markdown
Contributor Author

image

@RitvikSardana will fix this by EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants