Closed
Conversation
…eld added (cherry picked from commit 23b4429)
(cherry picked from commit 2535d34)
(cherry picked from commit 34e599e)
(cherry picked from commit a98bae5)
(cherry picked from commit 88de396)
…ix/pr-3959 fix: link to holiday list assignment in the message (backport frappe#3959)
ci: bump version automatically
## [16.0.2](frappe/hrms@v16.0.1...v16.0.2) (2026-01-15) ### Bug Fixes * link to holiday list assignment in the message ([3925847](frappe@3925847))
…e#3954)" (frappe#3967) * Revert "build: bump required frappe & erpnext version (backport frappe#3954)" * chore: remove dev version support --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 0d07ef4)
(cherry picked from commit 36d9973)
# [16.1.0](frappe/hrms@v16.0.2...v16.1.0) (2026-01-16) ### Bug Fixes * return 0 if no list is found ([c37cd2f](frappe@c37cd2f)) ### Features * number cards for leaves workspace ([6983372](frappe@6983372))
(cherry picked from commit 17509f6)
…appe#3936) (frappe#3996) Allows standard employees to view the organizational chart by default. Fixes frappe#3731 (cherry picked from commit b9d4e9c) Co-authored-by: G-karthick0501 <karthick.venger@gmail.com>
(cherry picked from commit 62188b8)
(cherry picked from commit 219149c)
…ix/pr-4002 fix: use boarding_status instead of status in Employee Separation (backport frappe#4002)
…ix/pr-4003 fix: leave approver shouldn't have amend permission on leave application (backport frappe#4003)
…ix/pr-3993 fix: check_app_permission returns False for Website Users (backport frappe#3993)
…uest (cherry picked from commit 71e95d7)
(cherry picked from commit 23f3a4e) Co-authored-by: Nareshkanna S <nareshkannashanmugam@gmail.com>
…ix/pr-4021 fix: update leave balance while cancelling the compensatory leave request (backport frappe#4021)
…pp is installed (cherry picked from commit 76c6cee)
…ix/pr-4034 fix(salary_register): show Loan Repayment column only when Lending app is installed (backport frappe#4034)
…or bulk attendance marking test: test unmarked days excluding holidays across two holiday assignments (cherry picked from commit ec3437e)
…arking attendance (cherry picked from commit 0e8db30)
(cherry picked from commit fb21a10)
…ix/pr-4035 fix: consider holiday list assignments while marking attendance in bulk (backport frappe#4035)
(cherry picked from commit fd7aa11)
(cherry picked from commit 93ea7c5)
…ix/pr-4038 fix: validate dates in additional salary (backport frappe#4038)
(cherry picked from commit 5bec6b2)
(cherry picked from commit 1d370ad)
(cherry picked from commit ee6440d) Co-authored-by: Raheel Khan <raheel@frappe.io>
…ix/pr-4055 fix(naming): use function appropriately to avoid double naming (backport frappe#4055)
…n name (cherry picked from commit 496f8ba)
…ix/pr-4061 fix(Bulk Salary Structure Assignment): use untranslated id to filter for column being updated (backport frappe#4061)
# [16.3.0](frappe/hrms@v16.2.0...v16.3.0) (2026-02-03) ### Bug Fixes * allow development server host ([frappe#4056](frappe#4056)) ([frappe#4058](frappe#4058)) ([17c6ceb](frappe@17c6ceb)) * avoid raising exception for unassigned holiday list while bulk marking attendance ([d711c98](frappe@d711c98)) * check_app_permission returns False for Website Users ([84013c4](frappe@84013c4)) * consider holiday list assignments while fetching unmarked days for bulk attendance marking ([1b186d4](frappe@1b186d4)) * correct patch name ([62309e9](frappe@62309e9)) * employee advance account's account type should be receivable ([f5dfd76](frappe@f5dfd76)) * **gratuity:** consider default amount ([frappe#4007](frappe#4007)) ([frappe#4033](frappe#4033)) ([ebcd828](frappe@ebcd828)) * **naming:** use function appropriately to avoid double naming ([508c324](frappe@508c324)) * payroll date validation in additional salary ([79655b0](frappe@79655b0)) * update leave balance while cancelling the compensatory leave request ([de1764c](frappe@de1764c)) * use untranslated id to filter column instead of translated column name ([460af65](frappe@460af65)) * **user-type:** add leave type read permission for employee self service ([8d1f4b1](frappe@8d1f4b1)) * validate dates in additional salary ([dabe358](frappe@dabe358)) ### Features * **api:** added guest API to fetch disable_user_pass_login system setting ([f5bdc4d](frappe@f5bdc4d)) * **login:** Show password login only if not disabled ([31ec4d2](frappe@31ec4d2)) * **salary_register:** show Loan Repayment column only when Lending app is installed ([4ec9d2b](frappe@4ec9d2b))
* add button to create journal entry for payroll * use sal slip doc * fix var * add option for payroll dates * fix query * fix days for payroll attendance report * fix var name * fix var name * fix holiday dates * fix lasd day in payroll view * exclude management from attendance report * fix query filter * fix missing day in the report * fix payroll payslip with zero salary entry * fix zero payable * fix error * fix zero payable * fix 0 payable * remove payble * revert changes * fix zero payable * tmp: disable submit * revert: tmp commit * fix * fix * fix * fix * fix * fix * fix * revert * exclude management * remove payroll dates * dont submit JV
p-dhan
requested review from
AyshaHakeem,
asmitahase and
ruchamahabal
as code owners
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates the codebase to version 16.3.0 and introduces several functional changes across authentication, payroll, leave management, and attendance systems. Key modifications include: adding a system setting to optionally disable password-based login with a conditional UI gate in the Login view; migrating release workflows and branch defaults from version-14 to version-16; refactoring holiday date retrieval logic with enhanced error handling and optional exception suppression; updating leave encashment calculations to prioritize Salary Structure Assignment lookups; improving payroll journal entry creation with new button controls; and adding validation constraints to attendance, expense claims, and leave application processing. Additionally, workspace navigation and various test coverage improvements are included. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Updates