fix: modify voucher type based on account type (backport #3842)#4249
Merged
iamkhanraheel merged 2 commits intoversion-15-hotfixfrom Mar 20, 2026
Merged
Conversation
Collaborator
|
🎉 This PR is included in version 15.58.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect voucher_type assignment
Payroll Entrywas always creating Journal Entries withvoucher_type = "Bank Entry"even when the selectedpayment_accountis a Cash account.The updated logic checks the
account_typeofpayment_accountand sets thevoucher_typeaccordingly (Bank Entry for bank accounts, Cash Entry for cash accounts).backport version-15-hotfix
backport version-16-hotfix
Summary by CodeRabbit
Bug Fixes
Tests
This is an automatic backport of pull request #3842 done by [Mergify](https://mergify.com).