fix(pwa): approval actions button for self leaves (backport #4395)

frontend/src/components/CheckInPanel.vue

@@ -77,11 +77,12 @@
 </template>
 
 <script setup>
-import { createResource, createListResource, toast, FeatherIcon } from "frappe-ui"
+import { createListResource, toast, FeatherIcon } from "frappe-ui"
 import { computed, inject, ref, onMounted, onBeforeUnmount } from "vue"
 import { IonModal, modalController } from "@ionic/vue"
 
 import { formatTimestamp } from "@/utils/formatters"
+import { settings } from "@/data/settings"
 
 const DOCTYPE = "Employee Checkin"
 
@@ -93,10 +94,6 @@ const checkinTimestamp = ref(null)
 const latitude = ref(0)
 const longitude = ref(0)
 const locationStatus = ref("")
-const settings = createResource({
-	url: "hrms.api.get_hr_settings",
-	auto: true,
-})
 
 const checkins = createListResource({
 	doctype: DOCTYPE,

frontend/src/components/RequestActionSheet.vue

@@ -171,6 +171,7 @@ import FilePreviewModal from "@/components/FilePreviewModal.vue"
 import WorkflowActionSheet from "@/components/WorkflowActionSheet.vue"
 
 import { getCompanyCurrency } from "@/data/currencies"
+import { settings } from "@/data/settings"
 import { formatCurrency } from "@/utils/formatters"
 
 import useWorkflow from "@/composables/workflow"
@@ -231,9 +232,16 @@ const permittedWriteFields = createResource({
 	auto: true,
 })
 
+const sessionEmployee = inject("$employee")
+
 function hasPermission(action) {
-	if (action === "approval")
+	if (action === "approval" && props.modelValue.doctype === "Leave Application"){
+		// prevent self leave approval
+		const isSelfLeave = document?.doc?.employee === sessionEmployee?.data?.name 
+		if (isSelfLeave && settings.data?.prevent_self_leave_approval)
+			return false
 		return permittedWriteFields.data?.includes(approvalField.value)
+	}
 	return docPermissions.data?.permissions[action]
 }
 
@@ -337,6 +345,7 @@ const openFormView = () => {
 onMounted(() => {
 	workflow.value = useWorkflow(props.modelValue.doctype)
 })
+
 </script>
 
 <style scoped>

frontend/src/components/RequestList.vue

@@ -37,7 +37,10 @@
 		:initial-breakpoint="1"
 		:breakpoints="[0, 1]"
 	>
-		<RequestActionSheet :fields="fieldsMap[selectedRequest?.doctype]" v-model="selectedRequest" />
+		<RequestActionSheet
+			:fields="fieldsMap[selectedRequest?.doctype]" 
+			v-model="selectedRequest"
+		/>
 	</ion-modal>
 </template>
 

frontend/src/data/settings.js

@@ -0,0 +1,6 @@
+import { createResource } from "frappe-ui"
+
+export const settings = createResource({
+	url: "hrms.api.get_hr_settings",
+	auto: true,
+})

hrms/api/__init__.py

@@ -92,6 +92,7 @@ def get_hr_settings() -> dict:
 	return frappe._dict(
 		allow_employee_checkin_from_mobile_app=settings.allow_employee_checkin_from_mobile_app,
 		allow_geolocation_tracking=settings.allow_geolocation_tracking,
+		prevent_self_leave_approval=settings.prevent_self_leave_approval,
 	)