Skip to content

fix(attendance-request): update days in attendance request list#4424

Merged
asmitahase merged 1 commit intofrappe:developfrom
aerele:attendance-request-list-PWA
Apr 22, 2026
Merged

fix(attendance-request): update days in attendance request list#4424
asmitahase merged 1 commit intofrappe:developfrom
aerele:attendance-request-list-PWA

Conversation

@nareshkannasln
Copy link
Copy Markdown
Contributor

@nareshkannasln nareshkannasln commented Apr 22, 2026

Issue: The total number of days is not correctly showing for the attendance request list in the HRMS Mobile app
The total days field renders the raw translation placeholder {0}d instead of the actual day count.

Before:

Screencast.from.2026-04-22.11-32-49.webm

After:

Screencast.from.2026-04-22.11-33-29.webm

Backport needed for v-15, v-16

Summary by CodeRabbit

  • Bug Fixes
    • Updated attendance request day count calculation to display more accurately based on actual attendance totals rather than date presence alone.

@nareshkannasln nareshkannasln force-pushed the attendance-request-list-PWA branch from f71182c to f62f5ef Compare April 22, 2026 12:40
@nareshkannasln nareshkannasln marked this pull request as ready for review April 22, 2026 12:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fbe3ce56-898e-4f86-8da0-7f86f6199a06

📥 Commits

Reviewing files that changed from the base of the PR and between 5c11f80 and f62f5ef.

📒 Files selected for processing (1)
  • frontend/src/components/AttendanceRequestItem.vue

Walkthrough

The AttendanceRequestItem.vue component was updated to change how the total attendance days count is displayed and when it appears. The conditional logic for rendering the trailing "{total}d" segment was modified from checking the presence of props.doc.to_date to checking if getTotalDays(props.doc) is greater than zero. Additionally, the displayed day count was changed from using props.doc.total_attendance_days directly to using the computed value from the getTotalDays() function. These changes ensure the component uses calculated values for consistency.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: updating how days are displayed in the attendance request list, which aligns with the changeset's purpose of fixing incorrect day count rendering.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asmitahase asmitahase merged commit 4359f48 into frappe:develop Apr 22, 2026
10 checks passed
asmitahase added a commit that referenced this pull request Apr 22, 2026
…4424

fix(attendance-request): update days in attendance request list (backport #4424)
asmitahase added a commit that referenced this pull request Apr 22, 2026
…4424

fix(attendance-request): update days in attendance request list (backport #4424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants