Skip to content

fix: clamp function arguments (backport #1015) #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mergify wants to merge 1 commit into from
Closed

fix: clamp function arguments (backport #1015) #1016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions insights/insights/doctype/insights_data_source_v3/ibis_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,17 @@ def get_current_columns(self):
return {col: getattr(self.query, col) for col in self.query.schema().names}


<<<<<<< HEAD
=======
def clamp(value, lo: int, hi: int) -> int:
"""Cast *value* to int and clamp it to [lo, hi], returning *default* on failure."""
try:
return max(lo, min(int(value), hi))
except (TypeError, ValueError):
return lo


>>>>>>> 8724803c (fix: clamp function arguments (#1015))
def execute_ibis_query(
query: IbisQuery,
limit=100,
Expand Down