Skip to content

fix: update max page_size (backport #1020) #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mergify wants to merge 1 commit into from
Closed

fix: update max page_size (backport #1020) #1021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions insights/insights/doctype/insights_data_source_v3/ibis_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,16 @@ def get_current_columns(self):
return {col: getattr(self.query, col) for col in self.query.schema().names}


<<<<<<< HEAD
=======
def clamp(value, lo: int, hi: int) -> int:
try:
return max(lo, min(int(value), hi))
except (TypeError, ValueError):
return lo


>>>>>>> 3eef8111 (fix: update max page_size (#1020))
def execute_ibis_query(
query: IbisQuery,
limit=100,
Expand All @@ -749,6 +759,15 @@ def execute_ibis_query(
reference_doctype=None,
reference_name=None,
):
<<<<<<< HEAD
=======
if hasattr(query, "limit"):
page_size = clamp(page_size, 1, 10_000)
page = clamp(page, 1, 10_000)
offset = (page - 1) * page_size
query = query.limit(page_size, offset=offset)

>>>>>>> 3eef8111 (fix: update max page_size (#1020))
try:
sql = ibis.to_sql(query)
except ibis.common.exceptions.OperationNotDefinedError:
Expand Down