refactor: centralize circular query dependency detection#1032
Merged
nextchamp-saqib merged 1 commit intodevelopfrom Apr 6, 2026
Merged
refactor: centralize circular query dependency detection#1032nextchamp-saqib merged 1 commit intodevelopfrom
nextchamp-saqib merged 1 commit intodevelopfrom
Conversation
nextchamp-saqib
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Apr 6, 2026
(cherry picked from commit b03eb3b)
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces 4 independent, ad-hoc circular reference guards with a unified approach:
extract_query_deps_from_operations,get_direct_dependencies,transitive_closure,find_cycleInsightsQueryv3.validate): cycles are now caught before being persisted, with a full cycle path in the error message (e.g."A" → "B" → "A")IbisQueryBuilder.build(): owns the runtime recursion guard (viafrappe.local) as a defensive fallbackget_source_tables(): rewritten usingtransitive_closure— drops the recursivevisitedparameter patternset_linked_queries(): simplified to a one-liner usingextract_query_deps_from_operationsgetLinkedQueries()(frontend): fixed a latent infinite-loop bug — adds a_visitedSet to guard against cycles in already-loaded datagetEffectiveOperationsForDrillDown()(frontend):_visitedQueryNames: string[]→_visitedQueries: Set<string>for O(1) lookups and consistent style