Skip to content

fix: Category dropdown options not visible in the certification list page #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pateljannat merged 4 commits into from
Dec 17, 2025
Merged

fix: Category dropdown options not visible in the certification list page #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8c10d1
fix: update certification categories to include label and value
KerollesFathy Dec 13, 2025
4580ab0
fix: add watcher for currentCategory to update participants
KerollesFathy Dec 13, 2025
49bc575
fix: prevent duplicate certification categories
KerollesFathy Dec 15, 2025
cfbac5f
fix: use `update:modelvalue` instead of using `watch`
KerollesFathy Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/pages/CertifiedParticipants.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
v-model="currentCategory"
:options="categories.data"
:placeholder="__('Category')"
@change="updateParticipants()"
@update:modelValue="updateParticipants()"
/>
</div>
</div>
Expand Down
7 changes: 5 additions & 2 deletions lms/lms/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,7 @@ def get_count_of_certified_members(filters=None):
@frappe.whitelist(allow_guest=True)
def get_certification_categories():
categories = []
seen = set()
docs = frappe.get_all(
"LMS Certificate",
filters={
Expand All @@ -448,9 +449,11 @@ def get_certification_categories():

for doc in docs:
category = doc.course_title if doc.course_title else doc.batch_title
if category not in categories:
categories.append(category)
if not category or category in seen:
continue

seen.add(category)
categories.append({"label": category, "value": category})
return categories


Expand Down