Skip to content

fix: misc issues#1928

Merged
pateljannat merged 4 commits into
frappe:developfrom
pateljannat:issues-164
Dec 23, 2025
Merged

fix: misc issues#1928
pateljannat merged 4 commits into
frappe:developfrom
pateljannat:issues-164

Conversation

@pateljannat
Copy link
Copy Markdown
Member

@pateljannat pateljannat commented Dec 22, 2025

  1. Fixed enrollment conditions
  2. Fixed Livecode default URL
  3. Don't fetch application count on job details when user is not logged in

@cypress
Copy link
Copy Markdown

cypress Bot commented Dec 22, 2025

lms    Run #1866

Run Properties:  status check passed Passed #1866  •  git commit d12982a756 ℹ️: Merge 30133727118d7512b42789b8904d5876d170cfd8 into 115d52776ffec1f58ad4026388ff...
Project lms
Branch Review issues-164
Run status status check passed Passed #1866
Run duration 01m 02s
Commit git commit d12982a756 ℹ️: Merge 30133727118d7512b42789b8904d5876d170cfd8 into 115d52776ffec1f58ad4026388ff...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat changed the title Issues 164 fix: misc issues Dec 23, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.52%. Comparing base (1d7c886) to head (3013372).
⚠️ Report is 114 commits behind head on develop.

Files with missing lines Patch % Lines
lms/lms/utils.py 25.00% 3 Missing ⚠️
.../doctype/course_evaluator/test_course_evaluator.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1928      +/-   ##
===========================================
+ Coverage    19.98%   28.52%   +8.53%     
===========================================
  Files          156      150       -6     
  Lines         4814     4814              
===========================================
+ Hits           962     1373     +411     
+ Misses        3852     3441     -411     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pateljannat pateljannat merged commit 0a9b18d into frappe:develop Dec 23, 2025
7 checks passed
@frappe-pr-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants