Skip to content

chore: merge 'develop' into 'main'#2053

Merged
pateljannat merged 63 commits into
mainfrom
develop
Feb 4, 2026
Merged

chore: merge 'develop' into 'main'#2053
pateljannat merged 63 commits into
mainfrom
develop

Conversation

@frappe-pr-bot
Copy link
Copy Markdown
Collaborator

Automated weekly release

raizasafeel and others added 30 commits January 16, 2026 11:37
Co-authored-by: Suraj Shetty <surajshetty3416@users.noreply.github.com>
* Earlier logic was flaky because the test calculated the last expected date using a 56‑day window, while the production code builds
  schedules for 60 days. Those extra 4 days sometimes include another Monday or Wednesday, so the schedule ends later than the test
  expects.
PR #1987 fixed the "+" (Add block) menu positioning but missed the
block settings menu (6-dot "Click to tune" icon) which uses a different
parent container (.ce-toolbar__actions instead of .ce-toolbox).

This adds the missing selector to fix both menus.

Related: #1990
When a lesson was deleted, the remaining lessons' idx values were not resequenced. This caused Add Lesson to navigate to an existing lesson instead of creating a new one, showing stale data in the form.
…-visibility

fix: prevent 'Create New' button from overlapping last dropdown element
…-back-navigation

fix(quiz): questions list empty on back navigation from test quiz
…details

fix(batch): restrict student list in batch details API to authorised roles
pateljannat and others added 27 commits January 29, 2026 20:32
feat: configurable frontend base path
fix: reindex lessons after deletion to prevent stale form state
…s-menu

fix: instructor notes block settings menu overlapped by sidebar
fix: issue date not coming from backend
fix: filter tabs not working in non-english languages
fix(batches): order assessments by their index
test(chapter): added reindexing test on chapter deletion
@cypress
Copy link
Copy Markdown

cypress Bot commented Feb 4, 2026

lms    Run #2016

Run Properties:  status check passed Passed #2016  •  git commit 0b03da4fc7 ℹ️: Merge 5384b26610057c1a5efd23a8043eacf3f2ef6719 into e8768d568775bfabcb3cb25552a0...
Project lms
Branch Review develop
Run status status check passed Passed #2016
Run duration 01m 01s
Commit git commit 0b03da4fc7 ℹ️: Merge 5384b26610057c1a5efd23a8043eacf3f2ef6719 into e8768d568775bfabcb3cb25552a0...
Committer MochaMind
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.34783% with 141 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.45%. Comparing base (b429fb2) to head (5384b26).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lms/lms/api.py 26.88% 68 Missing ⚠️
lms/lms/utils.py 37.93% 54 Missing ⚠️
lms/lms/test_helpers.py 89.51% 13 Missing ⚠️
...assignment_submission/lms_assignment_submission.py 0.00% 1 Missing ⚠️
...lms_certificate_request/lms_certificate_request.py 0.00% 1 Missing ⚠️
lms/lms/doctype/lms_enrollment/lms_enrollment.py 80.00% 1 Missing ⚠️
lms/lms/doctype/lms_payment/lms_payment.py 0.00% 1 Missing ⚠️
lms/lms/user.py 50.00% 1 Missing ⚠️
lms/www/_lms.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
+ Coverage   32.87%   36.45%   +3.57%     
==========================================
  Files         152      151       -1     
  Lines        5123     5100      -23     
==========================================
+ Hits         1684     1859     +175     
+ Misses       3439     3241     -198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pateljannat pateljannat merged commit 249ecb8 into main Feb 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants