fix(scorm): upload package zip as private file#2412
Closed
raizasafeel wants to merge 1 commit into
Closed
Conversation
lms
 |
||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
file-uploader
|
| Run status |
|
| Run duration | 00m 33s |
| Commit |
|
| Committer | Raizaaa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
1
|
| View all changes introduced in this branch ↗︎ | |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2412 +/- ##
===========================================
+ Coverage 47.74% 47.76% +0.02%
===========================================
Files 150 150
Lines 6658 6659 +1
===========================================
+ Hits 3179 3181 +2
+ Misses 3479 3478 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
private: true. Other uploads (cover images, settings images, etc) explicitly stay public