Skip to content

fix: job application page is now visible#2413

Merged
raizasafeel merged 1 commit into
frappe:developfrom
raizasafeel:temp/job-applications
May 19, 2026
Merged

fix: job application page is now visible#2413
raizasafeel merged 1 commit into
frappe:developfrom
raizasafeel:temp/job-applications

Conversation

@raizasafeel
Copy link
Copy Markdown
Contributor

Summary

  • The Job Applications page was not rendering due to createListResource asking for dotted-field joins (user.full_name as full_name, etc.) on LMS Job Application, which upstream frappe.client.get_list no longer supports.
  • Turned it to 2 queries:
    1. fetch applications first
    2. fetch the matching users via a whitelisted helper.

Note: Temp workaround until framework restores dotted joins (going to be reverted)

@cypress
Copy link
Copy Markdown

cypress Bot commented May 19, 2026

lms    Run #3689

Run Properties:  status check passed Passed #3689  •  git commit 609d482229 ℹ️: Merge 847b15e37bea6c159f4e1f5839ae78c4099d2d13 into cac0a8ef28835d1607d4b8680ca6...
Project lms
Branch Review temp/job-applications
Run status status check passed Passed #3689
Run duration 00m 32s
Commit git commit 609d482229 ℹ️: Merge 847b15e37bea6c159f4e1f5839ae78c4099d2d13 into cac0a8ef28835d1607d4b8680ca6...
Committer Raizaaa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.79%. Comparing base (41fb007) to head (847b15e).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
lms/lms/api.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2413      +/-   ##
===========================================
+ Coverage    47.74%   47.79%   +0.04%     
===========================================
  Files          150      150              
  Lines         6658     6691      +33     
===========================================
+ Hits          3179     3198      +19     
- Misses        3479     3493      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raizasafeel raizasafeel merged commit e5fd49c into frappe:develop May 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants