Skip to content

fix(router): install shared router for standalone AssessmentPlugin mounts #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IridescentGil wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −5
Open

fix(router): install shared router for standalone AssessmentPlugin mounts #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions frontend/src/utils/assignment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ import AssessmentPlugin from '@/components/AssessmentPlugin.vue'
import translationPlugin from '../translation'
import { usersStore } from '@/stores/user'
import { call } from 'frappe-ui'
import { useRouter } from 'vue-router'
import router from '@/router'
import { getLmsRoute } from '@/utils/basePath'

const router = useRouter()
export class Assignment {
constructor({ data, api, readOnly }) {
this.data = data
Expand Down
5 changes: 2 additions & 3 deletions frontend/src/utils/quiz.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { usersStore } from '../stores/user'
import translationPlugin from '../translation'
import { CircleHelp } from 'lucide-vue-next'
import { getLmsRoute } from '@/utils/basePath'
import { useRouter } from 'vue-router'

const router = useRouter()
import router from '@/router'

export class Quiz {
constructor({ data, api, readOnly }) {
Expand Down Expand Up @@ -69,6 +67,7 @@ export class Quiz {
},
})
app.use(translationPlugin)
app.use(router)
app.mount(this.wrapper)
}

Expand Down