Skip to content

chore: merge main hotfix to main#2421

Merged
raizasafeel merged 21 commits into
frappe:mainfrom
raizasafeel:sync/main-hotfix-to-main-v2
May 20, 2026
Merged

chore: merge main hotfix to main#2421
raizasafeel merged 21 commits into
frappe:mainfrom
raizasafeel:sync/main-hotfix-to-main-v2

Conversation

@raizasafeel
Copy link
Copy Markdown
Contributor

No description provided.

raizasafeel and others added 20 commits May 14, 2026 10:43
fix: system manager permissions are set properly on install
fix(certificate): permission and progress check
fix: race condition caused duplicate course progress
fix: drop member email from certified participants response
chore: merge `develop` into `main-hotfix`
@raizasafeel raizasafeel reopened this May 20, 2026
@raizasafeel raizasafeel changed the base branch from develop to main May 20, 2026 12:05
@cypress
Copy link
Copy Markdown

cypress Bot commented May 20, 2026

lms    Run #3731

Run Properties:  status check passed Passed #3731  •  git commit 3254c876cf ℹ️: Merge 481430a89f45b1ed4aa5f3c8c12e25cc3350f45e into 1c3b2e76d7f02d55c709cb4b8b0b...
Project lms
Branch Review sync/main-hotfix-to-main-v2
Run status status check passed Passed #3731
Run duration 00m 30s
Commit git commit 3254c876cf ℹ️: Merge 481430a89f45b1ed4aa5f3c8c12e25cc3350f45e into 1c3b2e76d7f02d55c709cb4b8b0b...
Committer Raizaaa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

❌ Patch coverage is 55.00000% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.81%. Comparing base (1c3b2e7) to head (481430a).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
lms/lms/api.py 25.00% 9 Missing ⚠️
lms/lms/doctype/course_lesson/course_lesson.py 0.00% 8 Missing ⚠️
lms/lms/doctype/lms_certificate/lms_certificate.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2421      +/-   ##
==========================================
+ Coverage   47.74%   47.81%   +0.06%     
==========================================
  Files         150      150              
  Lines        6658     6693      +35     
==========================================
+ Hits         3179     3200      +21     
- Misses       3479     3493      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…/main-hotfix-to-main-v2

# Conflicts:
#	lms/patches.txt
@raizasafeel raizasafeel force-pushed the sync/main-hotfix-to-main-v2 branch from 45e5c3b to 481430a Compare May 20, 2026 12:12
@raizasafeel raizasafeel merged commit c45ac18 into frappe:main May 20, 2026
9 checks passed
@raizasafeel raizasafeel deleted the sync/main-hotfix-to-main-v2 branch May 20, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants