Skip to content

fix(live-class): use emitted value from timezone Combobox - #2573

Open
nathanheintz wants to merge 1 commit into
frappe:developfrom
nathanheintz:fix/live-class-timezone-combobox
Open

fix(live-class): use emitted value from timezone Combobox#2573
nathanheintz wants to merge 1 commit into
frappe:developfrom
nathanheintz:fix/live-class-timezone-combobox

Conversation

@nathanheintz

Copy link
Copy Markdown

The timezone Combobox handler treated the emitted payload as an option object and read opt.value. frappe-ui's Combobox declares defineModel<string | null>(), so update:modelValue emits the value string — opt.value is undefined.

Selecting a timezone therefore cleared liveClass.timezone. Since the field is required, saving then failed validation with a 500.

Read the emitted string directly.

The timezone Combobox handler treated the emitted payload as an option object
and read `opt.value`. frappe-ui's Combobox declares `defineModel<string | null>()`,
so `update:modelValue` emits the value string — `opt.value` is undefined.

Selecting a timezone therefore cleared `liveClass.timezone`. Since the field is
required, saving then failed validation with a 500.

Read the emitted string directly.
@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — single targeted fix that correctly reads the emitted string from the Combobox.

The change is minimal and directly addresses the root cause: the Combobox emits a plain string, not an option object, so reading it directly is correct. No other logic is touched.

No files require special attention.

Reviews (1): Last reviewed commit: "fix(live-class): use emitted value from ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant