fix(live-class): use emitted value from timezone Combobox - #2573
Open
nathanheintz wants to merge 1 commit into
Open
fix(live-class): use emitted value from timezone Combobox#2573nathanheintz wants to merge 1 commit into
nathanheintz wants to merge 1 commit into
Conversation
The timezone Combobox handler treated the emitted payload as an option object and read `opt.value`. frappe-ui's Combobox declares `defineModel<string | null>()`, so `update:modelValue` emits the value string — `opt.value` is undefined. Selecting a timezone therefore cleared `liveClass.timezone`. Since the field is required, saving then failed validation with a 500. Read the emitted string directly.
Contributor
Confidence Score: 5/5Safe to merge — single targeted fix that correctly reads the emitted string from the Combobox. The change is minimal and directly addresses the root cause: the Combobox emits a plain string, not an option object, so reading it directly is correct. No other logic is touched. No files require special attention. Reviews (1): Last reviewed commit: "fix(live-class): use emitted value from ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timezone Combobox handler treated the emitted payload as an option object and read
opt.value. frappe-ui's Combobox declaresdefineModel<string | null>(), soupdate:modelValueemits the value string —opt.valueis undefined.Selecting a timezone therefore cleared
liveClass.timezone. Since the field is required, saving then failed validation with a 500.Read the emitted string directly.