Skip to content

feat: polls in chat#62

Open
dankgarlic1 wants to merge 9 commits into
frappe:developfrom
dankgarlic1:feat/polling-in-meeting-chat
Open

feat: polls in chat#62
dankgarlic1 wants to merge 9 commits into
frappe:developfrom
dankgarlic1:feat/polling-in-meeting-chat

Conversation

@dankgarlic1

Copy link
Copy Markdown
Contributor

closes #58

@BreadGenie

Copy link
Copy Markdown
Member

merged develop since the test was fixed (sorta)

@dankgarlic1 dankgarlic1 force-pushed the feat/polling-in-meeting-chat branch from 296de0b to 05c64ee Compare June 13, 2026 11:19
@dankgarlic1 dankgarlic1 marked this pull request as ready for review June 13, 2026 11:20
@dankgarlic1

Copy link
Copy Markdown
Contributor Author

jam: https://jam.dev/c/e8b82540-19be-4deb-96a6-2cb94a40dc6c

the color scheme sucks and I am not sure what to have, can you suggest like on the overall ui what has to be changed?
@BreadGenie

@BreadGenie BreadGenie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the UI. Especially the card inside card UI feels a bit vibed. I'd rather we use black and white theme as usual in espresso design. Give it a shot without other colours. You can take a look at other products for inspiration.

Also, we need to fix the inconsistency in the terminology. Let's stick with create poll instead of launch poll.

Few additional things I'd like to see

  • View who voted. Currently it looks anonymous.
  • Poll deadline

These can be added in this PR or a separate one.

@dankgarlic1

Copy link
Copy Markdown
Contributor Author

I feel these things should be done in a separate pr

  • View who voted. Currently it looks anonymous.
  • Poll deadline

will create issues for that

rest yes I'll give it a shot for ui, thanks

@dankgarlic1

Copy link
Copy Markdown
Contributor Author

btw what design inspirations you took while making meet?

@BreadGenie

Copy link
Copy Markdown
Member

btw what design inspirations you took while making meet?

I went with whatever I thought made sense. I'll do a redesign very soon btw. Because a lot of things are inconsistent.

@BreadGenie BreadGenie changed the title Feat/polling in meeting chat feat: polls in chat Jun 15, 2026
@dankgarlic1 dankgarlic1 force-pushed the feat/polling-in-meeting-chat branch from 05c64ee to 68ef7cc Compare June 17, 2026 10:24
@dankgarlic1

Copy link
Copy Markdown
Contributor Author

@BreadGenie hey I updated the color scheme: https://jam.dev/c/c42e3c51-6258-4f16-99b5-f8bff43f2a39

I like it, its simple and just nice matches the vibe of all the frappe products, lmk what you think

@dankgarlic1

Copy link
Copy Markdown
Contributor Author

although I do feel the way that drop down is positioned is idk not the best I feel, lmk what you think, happy to rework on it if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Real-time Polling via Control Bar with In-Chat Voting

2 participants