Skip to content

fix(dashboard): Padding (x-axis) on roles permissions cards#6418

Merged
ssiyad merged 1 commit into
developfrom
fix/roles/permissions_padding
May 12, 2026
Merged

fix(dashboard): Padding (x-axis) on roles permissions cards#6418
ssiyad merged 1 commit into
developfrom
fix/roles/permissions_padding

Conversation

@ssiyad

@ssiyad ssiyad commented May 12, 2026

Copy link
Copy Markdown
Member

No description provided.

@ssiyad ssiyad requested a review from siduck as a code owner May 12, 2026 12:28
@greptile-apps

greptile-apps Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes missing horizontal padding on the roles-permissions cards in the dashboard settings by adding px-2 to each of the four card group wrappers (Important, General, Resources, Partner). It also removes a leftover console.log('props', props) debug statement and normalizes string quotes from single to double across the script block.

  • Padding fix: px-2 is added to all four border rounded card containers, addressing the x-axis spacing issue consistently across every permission group.
  • Debug cleanup: The stray console.log that was printing props to the browser console is removed, which was likely introduced during development.
  • Quote normalization: All single-quoted strings in the <script setup> section are updated to double quotes, matching a consistent style.

Confidence Score: 5/5

Safe to merge — changes are purely cosmetic (padding) and a debug cleanup with no logic impact.

The change adds horizontal padding to four card containers, removes a debug console.log, and normalizes quote style. All four permission groups are updated consistently, so there is no risk of one group being missed. No logic, data flow, or component API is altered.

No files require special attention.

Important Files Changed

Filename Overview
dashboard/src/components/settings/RolePermissions.vue Adds px-2 horizontal padding to all four permission card groups, removes a leftover console.log debug statement, and normalizes string quotes from single to double throughout the script block.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[RolePermissions.vue] --> B[permissionsImportant cards]
    A --> C[permissionsGeneral cards]
    A --> D[permissionsResources cards]
    A --> E[permissionsPartner cards]
    B --> F["border rounded px-2 (was: border rounded)"]
    C --> F
    D --> F
    E --> F
    F --> G[Switch toggle + label rendered with horizontal padding]
Loading

Reviews (1): Last reviewed commit: "fix(dashboard): Padding (x-axis) on role..." | Re-trigger Greptile

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.73%. Comparing base (55cc5b8) to head (ea2a5f7).
⚠️ Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6418      +/-   ##
===========================================
+ Coverage    49.79%   59.73%   +9.94%     
===========================================
  Files          945      110     -835     
  Lines        78270    17357   -60913     
  Branches       355      355              
===========================================
- Hits         38972    10369   -28603     
+ Misses       39275     6965   -32310     
  Partials        23       23              
Flag Coverage Δ
dashboard 59.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ssiyad ssiyad merged commit a76caac into develop May 12, 2026
13 checks passed
@ssiyad ssiyad deleted the fix/roles/permissions_padding branch May 12, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant