fix(build): Correct container mounts#6428
Conversation
|
| Filename | Overview |
|---|---|
| press/press/doctype/deploy_candidate_build/deploy_candidate_build.py | Adds the missing _set_container_mounts() call before Dockerfile generation so doc.container_mounts is populated when the template renders the custom-mount loop. |
Sequence Diagram
sequenceDiagram
participant DCB as DeployCandidateBuild
participant DC as DeployCandidate (candidate)
participant DB as Database
participant T as Dockerfile Template
DCB->>DC: _set_additional_packages()
DC-->>DC: "self.additional_packages = [...]"
Note over DCB,DC: NEW (this PR)
DCB->>DC: _set_container_mounts()
DC->>DB: frappe.get_all("Release Group Mount", ...)
DB-->>DC: "[{destination: ...}, ...]"
DC-->>DC: "self.container_mounts = [...]"
DCB->>DCB: _generate_dockerfile()
DCB->>T: "render(doc=self.candidate)"
T-->>T: iterate doc.additional_packages ✓
T-->>T: iterate doc.container_mounts ✓ (was empty without fix)
T-->>DCB: rendered Dockerfile string
Reviews (1): Last reviewed commit: "fix(build): Correctly set container moun..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6428 +/- ##
========================================
Coverage 49.79% 49.79%
========================================
Files 945 945
Lines 78271 78272 +1
Branches 355 355
========================================
+ Hits 38976 38978 +2
+ Misses 39272 39271 -1
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Purely for self hosted deployments correctly add container mounts in the
Dockerfile