Skip to content

Drop unused payments dependency (blocks v16 installs) - #412

Open
cormaza wants to merge 1 commit into
frappe:version-16from
cormaza:poc/drop-payments-dep
Open

cormaza wants to merge 1 commit into
frappe:version-16from
cormaza:poc/drop-payments-dep

Conversation

@cormaza

@cormaza cormaza commented Oct 22, 2026

Copy link
Copy Markdown

Problem

Installing webshop on a Frappe/ERPNext v16 bench fails at the dependency gate:

required_apps = ["payments", "erpnext"] demands the payments app, which has no v15/v16 release (latest stable: version-14). And payments v14 cannot migrate on v16: it collides with module defs the core absorbed (DuplicateEntry: Module Def 'Payments' / 'Payment Gateways') on top of missing deps (No module named 'Crypto').

Why dropping it is safe

  • Zero code references: no import payments / from payments anywhere in the app (only this declaration + the pyproject.toml frappe-dependencies entry, both removed here).
  • The only related doctypes (Payment Gateway Account link in Webshop Settings + read in shopping_cart/cart.py) already live in ERPNext core v16.

Evidence (PoC)

  • bench --site demo install-app webshop from this branch: migrates clean, "Thank you for installing Frappe Webshop!".
  • Webshop Settings opens; cart Quotation (order_type = "Shopping Cart") + place_order path usable as data source for third-party fiscal localizations (our case: Ecuadorian SRI emission points per shop).
  • Frontend build was not re-verified here (environmental yarn failure in our bench, unrelated to this change).

Changes

  • webshop/hooks.py: required_apps = ["erpnext"]
  • pyproject.toml: drop payments from [tool.bench.frappe-dependencies

Happy to retarget or split if you prefer keeping the pin for Frappe Cloud deploys that still need it.

@mergify

mergify Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The dependency changes appear safe to merge.

Reviews (1) · Last reviewed commit: "poc: drop unused payments dependency (bl..." · Reviewed by Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant