Repository navigation
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
[Medium impact] The dependency changes appear safe to merge. Reviews (1) · Last reviewed commit: "poc: drop unused payments dependency (bl..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing webshop on a Frappe/ERPNext v16 bench fails at the dependency gate:
required_apps = ["payments", "erpnext"]demands thepaymentsapp, which has no v15/v16 release (latest stable:version-14). Andpaymentsv14 cannot migrate on v16: it collides with module defs the core absorbed (DuplicateEntry: Module Def 'Payments'/'Payment Gateways') on top of missing deps (No module named 'Crypto').Why dropping it is safe
import payments/from paymentsanywhere in the app (only this declaration + thepyproject.tomlfrappe-dependenciesentry, both removed here).Payment Gateway Accountlink in Webshop Settings + read inshopping_cart/cart.py) already live in ERPNext core v16.Evidence (PoC)
bench --site demo install-app webshopfrom this branch: migrates clean, "Thank you for installing Frappe Webshop!".order_type = "Shopping Cart") +place_orderpath usable as data source for third-party fiscal localizations (our case: Ecuadorian SRI emission points per shop).Changes
webshop/hooks.py:required_apps = ["erpnext"]pyproject.toml: droppaymentsfrom[tool.bench.frappe-dependenciesHappy to retarget or split if you prefer keeping the pin for Frappe Cloud deploys that still need it.