Feat/33 tabs action ux - Add three dots kebab menu visible only on hover of active tab #38
Open
shawnriju wants to merge 3 commits into
Open
Feat/33 tabs action ux - Add three dots kebab menu visible only on hover of active tab #38shawnriju wants to merge 3 commits into
shawnriju wants to merge 3 commits into
Conversation
Collaborator
|
@shawnriju we're hiring for Frappe Writer. Would you be interested in applying? DM me @realsafwan if you're in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Main fix: Adds a kebab menu (three-dots) button to the active tab of the document, providing quick access to actions (rename, copy link and delete ) without requiring a right-click context menu.
Refinements based on maintainer feedback:
My initial approach
When I first implemented this, I added the kebab menu button directly to the right of the existing Plus/Minus button on the tab container, with both buttons always visible.
Feedback received
@safwansamsudeen requested that the kebab menu should only show when the active tab is hovered upon.
Why I made the additional changes
Keeping the kebab menu hover-only while leaving the Expand/Collapse button always visible would create inconsistent UI behavior on the active tab (one button appearing on hover, another always there). This could cause some confusion for users.
Final solution
This creates clear visual separation:
Video recording of the happy case
updated-toc-action-menu-demo.mp4
(Video shows: kebab menu appears on tab hover → actions can be selected → kebab disappears on mouse leave → expand/collapse always accessible on left)
Additional suggestion (separate PR)
I believe an Arrow icon would be more intuitive than Plus/Minus for expand/collapse functionality. However, I've kept this out of the current PR to maintain focus. If the team agrees, I'm happy to open a separate PR for that icon change.
Note about additional code changes in this PR
I'm developing on WSL (Windows Subsystem for Linux). When I ran
pre-commiton theToC.vuefile, Prettier automatically formatted the file according to the project's or (I assume) my system's configuration.This means: The diff shows more changes than just my manual code modifications because Prettier made formatting adjustments to existing code. No functional changes were made outside of the kebab menu implementation described above.
What was solved
This solves the issue: Tabs Actions UX #33 (adding kebab menu) with the requested hover behavior, plus a layout adjustment for UI consistency. Open to feedback and further adjustments if needed.