Feature/config updates

[frasermolyneux]

This pull request introduces Azure App Configuration as a centralized configuration provider for the .NET 9 Azure Functions app, replacing direct environment variable usage for most app settings. It also updates the FTP certificate thumbprint configuration to use a new key name and ensures case-insensitive comparison. Several Terraform variables and settings are cleaned up to reflect the new configuration approach.

Azure App Configuration Integration:

• The app now connects to Azure App Configuration if AzureAppConfiguration:Endpoint is set, loading configuration keys with environment-specific labels and supporting Key Vault references. This is implemented in Program.cs and documented in .github/copilot-instructions.md. [1] [2]
• Added the Microsoft.Extensions.Configuration.AzureAppConfiguration NuGet package to enable this integration.

Configuration Key Updates:

• The FTP certificate thumbprint setting is renamed from xtremeidiots_ftp_certificate_thumbprint to XtremeIdiots:FtpCertificateThumbprint throughout the codebase, and comparisons are now case-insensitive and null-safe. [1] [2] [3] [4]

Terraform and Infrastructure Cleanup:

• Removed direct app setting assignments for API URLs, audiences, and FTP certificate thumbprint in terraform/function_app.tf, reflecting the move to centralized configuration.
• Removed the geo_location_api variable and related data from terraform/tfvars/dev.tfvars, terraform/tfvars/prd.tfvars, and terraform/variables.tf. [1] [2] [3]

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details
nuget/Microsoft.Extensions.Configuration.AzureAppConfiguration	8.1.2	Unknown	Unknown

Scanned Files

• src/XtremeIdiots.Portal.Repository.App/XtremeIdiots.Portal.Repository.App.csproj

[github-actions]

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

	Count
➕ Add	5

📋 Resource Details

Action	Resource
➕ Create	azurerm_linux_function_app.function_app
➕ Create	azurerm_monitor_activity_log_alert.rg_resource_health
➕ Create	azurerm_role_assignment.app-to-storage
➕ Create	azurerm_storage_account.function_app_storage
➕ Create	random_id.environment_id

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.1% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

This pull request migrates the application from direct environment variable configuration to Azure App Configuration as a centralized configuration provider. The changes introduce a bootstrap pattern where the app connects to Azure App Configuration (when AzureAppConfiguration:Endpoint is set) to load environment-specific settings, including Key Vault references. Additionally, the FTP certificate thumbprint configuration key is standardized and made more robust with case-insensitive and null-safe comparison.

Changes:

• Integrated Azure App Configuration with environment-specific label selectors for centralized configuration management
• Renamed and improved FTP certificate thumbprint configuration from xtremeidiots_ftp_certificate_thumbprint to XtremeIdiots:FtpCertificateThumbprint with case-insensitive comparison
• Removed hardcoded API settings and GeoLocation API variables from Terraform, moving them to Azure App Configuration

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.github/copilot-instructions.md	Updated architecture and configuration documentation to reflect Azure App Configuration integration
terraform/variables.tf	Removed geo_location_api variable as settings moved to Azure App Configuration
terraform/tfvars/dev.tfvars	Removed GeoLocation API configuration block
terraform/tfvars/prd.tfvars	Removed GeoLocation API configuration block
terraform/function_app.tf	Removed direct app setting assignments for API URLs and audiences, now loaded from Azure App Configuration
src/XtremeIdiots.Portal.Repository.App/XtremeIdiots.Portal.Repository.App.csproj	Added Microsoft.Extensions.Configuration.AzureAppConfiguration package v8.1.2
src/XtremeIdiots.Portal.Repository.App/Program.cs	Implemented Azure App Configuration bootstrap with environment-specific label selectors and Key Vault integration
src/XtremeIdiots.Portal.Repository.App/Functions/UpdateLiveLogFile.cs	Updated FTP certificate thumbprint to new key name with null-safe and case-insensitive comparison
src/XtremeIdiots.Portal.Repository.App/Functions/UpdateBanFileMonitorConfig.cs	Updated FTP certificate thumbprint to new key name with null-safe and case-insensitive comparison (2 locations)