Refactor null checks in mapping extensions for improved readability

- Updated mapping extensions across various files to use braces for null checks, enhancing code clarity and consistency.
- Ensured that all relevant properties are checked and assigned properly in the mapping methods.
- This change applies to UserProfilesMappingExtensions, TagsMappingExtensions, RecentPlayersMappingExtensions, PlayersMappingExtensions, NotificationsMappingExtensions, MapRotationsMappingExtensions, GameServersMappingExtensions, ConnectedPlayersMappingExtensions, CentralBanFileStatusMappingExtensions, BanFileMonitorsMappingExtensions, and AdminActionsMappingExtensions.
- Additionally, refactored user profile retrieval methods in UserProfileController to consistently handle null checks and return appropriate API results.

Author: frasermolyneux

.editorconfig

@@ -44,7 +44,7 @@ dotnet_diagnostic.CA1716.severity = suggestion
 dotnet_diagnostic.CA1720.severity = suggestion
 
 # Defer broad style-only churn in existing code.
-dotnet_diagnostic.IDE0011.severity = suggestion
+dotnet_diagnostic.IDE0011.severity = warning
 dotnet_diagnostic.IDE0022.severity = suggestion
 dotnet_diagnostic.IDE0028.severity = suggestion
 dotnet_diagnostic.IDE0040.severity = suggestion

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/AdminActions/AdminActionDto.cs

@@ -62,10 +62,14 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (UserProfile is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(UserProfile.TelemetryProperties);
+                }
 
                 if (Player is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(Player.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/BanFileMonitors/BanFileMonitorDto.cs

@@ -157,7 +157,9 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (GameServer is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(GameServer.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/ChatMessages/ChatMessageDto.cs

@@ -68,10 +68,14 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (GameServer is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(GameServer.TelemetryProperties);
+                }
 
                 if (Player is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(Player.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/Demos/DemoDto.cs

@@ -67,7 +67,9 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (UserProfile is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(UserProfile.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/GameServers/GameServerEventDto.cs

@@ -41,7 +41,9 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (GameServer is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(GameServer.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/Maps/MapVoteDto.cs

@@ -49,13 +49,19 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (GameServer is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(GameServer.TelemetryProperties);
+                }
 
                 if (Map is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(Map.TelemetryProperties);
+                }
 
                 if (Player is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(Player.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/Players/LivePlayerDto.cs

@@ -74,7 +74,9 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (Player is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(Player.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/Players/ProtectedNameDto.cs

@@ -63,7 +63,9 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (CreatedByUserProfile is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(CreatedByUserProfile.TelemetryProperties);
+                }
 
                 return telemetryProperties;
             }

src/XtremeIdiots.Portal.Repository.Abstractions.V1/Models/V1/RecentPlayers/RecentPlayerDto.cs

@@ -61,7 +61,9 @@ public Dictionary<string, string> TelemetryProperties
                 };
 
                 if (Player is not null)
+                {
                     telemetryProperties.AddAdditionalProperties(telemetryProperties);
+                }
 
                 return telemetryProperties;
             }