Skip to content

Suppress CA1707 warnings for test method names#111

Merged
frasermolyneux merged 2 commits into
mainfrom
copilot/resolve-dotnet-warnings
Feb 14, 2026
Merged

Suppress CA1707 warnings for test method names#111
frasermolyneux merged 2 commits into
mainfrom
copilot/resolve-dotnet-warnings

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 13, 2026

Build was failing with 80 CA1707 warnings from test method names using underscores (e.g., Constructor_WithNullHttpClientFactory_ThrowsArgumentNullException).

Changes

  • Added <NoWarn>$(NoWarn);CA1707</NoWarn> to test project configuration
<PropertyGroup>
  <TargetFramework>net9.0</TargetFramework>
  <!-- ... -->
  <!-- Suppress CA1707: Underscores in test method names are acceptable for readability -->
  <NoWarn>$(NoWarn);CA1707</NoWarn>
</PropertyGroup>

Underscores in test method names follow the Method_Scenario_Expected pattern used throughout the test suite. Suppression scoped to test project only.

Original prompt

look at the last build-and-test output and resolve all the dotnet warnings. the build should have zero warnings when completed.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ames

Co-authored-by: frasermolyneux <34033625+frasermolyneux@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix all dotnet warnings in build output Suppress CA1707 warnings for test method names Feb 13, 2026
Copilot AI requested a review from frasermolyneux February 13, 2026 23:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 14, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@frasermolyneux frasermolyneux marked this pull request as ready for review February 14, 2026 05:21
Copilot AI review requested due to automatic review settings February 14, 2026 05:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves build failures caused by 80 CA1707 analyzer warnings from test method names using underscores. The solution suppresses CA1707 specifically for the test project, preserving the established Method_Scenario_Expected naming pattern used throughout the test suite.

Changes:

  • Added <NoWarn>$(NoWarn);CA1707</NoWarn> to the test project configuration with explanatory comment

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Terraform Plan

🌍 Environment: dev

✅ Validate — Passed

✅ Plan

No changes. Your infrastructure matches the configuration.

@sonarqubecloud
Copy link
Copy Markdown

@frasermolyneux frasermolyneux merged commit 5064f21 into main Feb 14, 2026
31 checks passed
@frasermolyneux frasermolyneux deleted the copilot/resolve-dotnet-warnings branch February 14, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants