Add unit test infrastructure with xUnit, Moq, and coverlet

[Copilot]

Add Unit Test Infrastructure to XtremeIdiots.Portal.Web

Implementation Plan

• Explore repository and reference project structure
• Create XtremeIdiots.Portal.Web.Tests project
• Configure test project with xUnit, Moq, and coverlet collector
• Add test project to solution file
• Create basic unit tests for ClaimsPrincipalExtensions
• Create basic unit tests for IPAddressExtensions
• Create basic unit tests for ProxyCheckService
• Build and verify tests run successfully
• Clean up and final verification
• Address PR review feedback (round 1)
• Address PR review feedback (round 2)
• Address PR review feedback (round 3)

Summary

Successfully added unit test infrastructure to the XtremeIdiots.Portal.Web project with 40 passing tests across 3 test classes.

Changes Made (Latest Commit)

PR Review Feedback Addressed (Round 3):

• ✅ Updated test project GUID in solution file from legacy C# project type GUID (FAE04EC0-301F-11D3-BF4B-00C04F79EFBC) to SDK-style GUID (9A19103F-16F7-4668-BE54-9A1E7A4F7556) for consistency with other projects and to avoid potential IDE/tooling quirks

Previous Changes (Round 2):

• ✅ Refactored GetIpRiskDataAsync_WithHttpError_ReturnsErrorResult test to use using var statements instead of try-finally block for cleaner resource management

Previous Changes (Round 1):

1. ✅ Aligned xUnit versions (2.9.3) with runner (2.8.2) to prevent test discovery issues
2. ✅ Added PrivateAssets="all" to coverlet.collector and xunit.runner.visualstudio packages
3. ✅ Removed x86/x64 solution configurations, keeping only Any CPU
4. ✅ Fixed nullable reference warning in IPAddressExtensionsTests using null-forgiving operator
5. ✅ Fixed disposable resource leaks in ProxyCheckServiceTests by properly disposing HttpResponseMessage and HttpClient

Tests Created

1. ClaimsPrincipalExtensionsTests (13 tests)

   • Tests for Username, Email, XtremeIdiotsId extraction
   • Tests for UserProfileId and PhotoUrl claims
   • Tests for ClaimedGamesAndItems with various claim types
   • Tests for GetGameTypesForGameServers

2. IPAddressExtensionsTests (17 tests)

   • Tests for FormatIPAddress with various parameters
   • Tests for null/empty IP address handling
   • Tests for risk score badge classes (high, medium, low, very low)
   • Tests for proxy/VPN flags
   • Tests for linking behavior

3. ProxyCheckServiceTests (10 tests)

   • Constructor validation tests
   • Tests for empty/null IP address handling
   • Tests for cached results
   • Tests for missing API key scenario
   • Tests for HTTP error handling
   • Tests for ProxyCheckResult.GetRiskClass

Test Configuration

• Framework: xUnit 2.9.3 (aligned with runner)
• Runner: xunit.runner.visualstudio 2.8.2
• Mocking: Moq 4.20.72
• Coverage: coverlet.collector 6.0.4 (with PrivateAssets)
• Target Framework: .NET 9.0 (net9.0)
• Language Version: C# 13

Test Results

All tests pass successfully:

Total tests: 40
     Passed: 40
     Failed: 0
   Skipped: 0

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

Adds a dedicated unit test project to the Portal Web solution to establish a baseline regression safety net for extension methods and the ProxyCheckService, helping catch runtime breaks introduced by dependency updates.

Changes:

• Added XtremeIdiots.Portal.Web.Tests project (net9.0) with xUnit, Moq, and coverlet collector, and referenced it from the web project.
• Introduced initial unit test suites for claims principal extensions, IP address formatting extensions, and ProxyCheckService.
• Added a README describing test structure and how to run tests/coverage.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/XtremeIdiots.Portal.Web.sln	Adds the new test project to the solution and updates solution configurations.
src/XtremeIdiots.Portal.Web.Tests/XtremeIdiots.Portal.Web.Tests.csproj	Introduces the test project configuration and test-related NuGet dependencies.
src/XtremeIdiots.Portal.Web.Tests/Extensions/ClaimsPrincipalExtensionsTests.cs	Adds unit tests for claims extraction and game/server claim filtering.
src/XtremeIdiots.Portal.Web.Tests/Extensions/IPAddressExtensionsTests.cs	Adds unit tests for HTML/IP formatting, badges, and link behavior.
src/XtremeIdiots.Portal.Web.Tests/Services/ProxyCheckServiceTests.cs	Adds unit tests for ProxyCheckService behavior including caching and error paths.
src/XtremeIdiots.Portal.Web.Tests/README.md	Documents how to run tests and the intended test structure/coverage areas.

[frasermolyneux]

@copilot apply changes based on the comments in this thread

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[frasermolyneux]

@copilot apply changes based on the comments in this thread

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[sonarqubecloud]

Quality Gate passed

Issues
40 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud