Update workflow permissions and enhance environment variable#91
Merged
Conversation
… in PR verification
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
frasermolyneux
temporarily deployed
to
Development
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to refine Terraform plan execution logic and improve dependency review feedback on pull requests, aligning CI/CD behavior with label-driven controls and enabling PR comment output for dependency changes.
Changes:
- Adjust Terraform plan job conditions in
pr-verify.ymlto rely on labels (and add conditional Azure client ID selection via jobenv). - Increase
pull-requestspermission and enable always-on PR summary comments for dependency review incodequality.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/pr-verify.yml | Updates Terraform plan job if: conditions and centralizes Azure credential values via job-level env, including a Dependabot-specific client ID option. |
| .github/workflows/codequality.yml | Grants PR write permission to dependency review job and configures dependency review to always comment a summary in PRs. |
frasermolyneux
temporarily deployed
to
Development
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the GitHub Actions workflows, primarily focusing on permissions, environment variable handling, and workflow conditions. The changes enhance security and flexibility for Terraform plan jobs, and improve dependency review feedback.
Workflow condition and environment variable improvements:
pr-verify.ymlto remove explicit exclusion of Dependabot PRs, relying instead on label-based control. This simplifies workflow logic and ensures more predictable execution. [1] [2]env:) and conditional assignment forAZURE_CLIENT_IDto support Dependabot PRs using a separate client ID. This improves security and flexibility for CI/CD jobs. [1] [2]Permissions and dependency review enhancements:
pull-requestspermission fromreadtowriteincodequality.yml, allowing the dependency review action to post summary comments directly in PRs.comment-summary-in-pr: alwaysfor the dependency review action, improving visibility of dependency changes.Workflow documentation update:
pr-verify.ymlto clarify workflow control, removing outdated references to Dependabot exclusion.