docs: point the key pair links at the anchors that exist - #88
Merged
Conversation
Two pages linked to `#authorization-key-pair` and `#blockchain-key-pair`,
but those headings declare explicit `{#akp}` and `{#bkp}` anchors, so
both links landed at the top of the page instead of the section. The
build does not catch this: it validates file paths, not fragments.
While there, the Kotlin note in the transaction tutorial called the
64-character key a truncated representation, which now contradicts the
naming used everywhere else. It says which form each example takes.
Signed-off-by: Dmitrii Creed <creeed22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two pages link to
#authorization-key-pairand#blockchain-key-pairon the Web App UI page, but those two headings declare explicit anchors,{#akp}and{#bkp}. The rendered page therefore contains no such ids, and both links drop the reader at the top of the page instead of the section they were sent to. Verified against the live site: it servesid="akp"andid="bkp"only.pnpm docs:builddoes not catch this, because its dead-link check validates file paths, not fragments.What changed
getting-started/calling-api-endpoints.mdandtutorials-api/signing-transactions.mdnow link to#akpand#bkp.Verification
pnpm docs:buildandprettier --checkpass. Anchors confirmed against the rendered HTML.