-
Notifications
You must be signed in to change notification settings - Fork 8
Extend availability of ensemble score estimators #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frazane
requested changes
Aug 31, 2025
Owner
frazane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good overall, only missing a few tests
frazane
approved these changes
Sep 4, 2025
frazane
pushed a commit
that referenced
this pull request
Sep 4, 2025
* add fair energy score * add fair variogram score * add fair gufuncs for energy and variogram scores * add akr estimators for energy score in numba * fix bug in fair gks * update documentation of fair kernel scores * add akr estimators for the Gaussian kernel score * estimator bug fix in weighted crps tests * fix bug in fair kernel scores * fix bugs in variogram scores * set p = 0.5 as default in variogram scores * fix bug in ow and vr energy score gufuncs * reduce tolerance of vres vs es test * add roll function to backends * add crps estimators for non-numba backends * add test of equality of crps estimators * add akr estimators for energy score for non-numba backends * remove TODO in energy score test * fix bug in torch crps estimator test * add akr estimators for gaussian kernel scores for non-numba backends * update default crps estimator * change tolerance of vertically rescaled variogram score test * add crps int estimator for non-numba backends * add tests for energy score estimators * add tests for fair variogram score * add tests for kernel score estimators Co-authored-by: Simon Hirsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.