Skip to content

Fixes the issue in which the root html element is added to the cfi - #15

Open
halmos wants to merge 1 commit into
fread-ink:masterfrom
halmos:issue-14
Open

Fixes the issue in which the root html element is added to the cfi#15
halmos wants to merge 1 commit into
fread-ink:masterfrom
halmos:issue-14

Conversation

@halmos

@halmos halmos commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

See issue #14 and #10.

Please note: I was not able to understand if the CFI test at:

cfiStr = 'epubcfi(/2/4/2[!/^[^]^,^;]/2/4[!/foo^^^[^]]/1:10)';

should expected to be

cfiStr = 'epubcfi(/4/2[!/^[^]^,^;]/2/4[!/foo^^^[^]]/1:10)';

or

cfiStr = 'epubcfi(/4/2[!/^[^]^,^;]/4[!/foo^^^[^]]/1:10)';

Currently, the code is producing the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant