Open
Conversation
Owner
|
Hi @Florian-BACHO ! Thanks for the contribution and sorry for the delay in reviewing. I'll take a closer look but why did you rename the package? |
Author
|
Hi, I renamed it because I needed it quickly via PyPi for another project and I didn't want it to clash with yours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The native HTML date picker does not support selecting date ranges. To address this limitation, I have replaced the native date picker with Flatpickr, which enables the selection of date ranges.
Closes: #6
Key Changes
New
modeParameterA new parameter,
mode, has been added to theCalendarcomponent. This parameter allows users to choose between two modes:Date Formatting
The default date format ("YYYY-MM-DD") has been preserved. When a date range is selected, it is formatted as "YYYY-MM-DD to YYYY-MM-DD".
Frontend Updates
Updated
predictFunction SignatureThe signature of the
predictfunction has been updated to support both single date values and date ranges, particularly when the "range" mode is enabled. The new signature is:predictfunction can now accept either a tuple of strings (representing a range of dates) or a tuple ofdatetimeobjects.predictfunction will still accept a single string ordatetimeobject, as before.Impact on Existing Behavior
predictFunction: Thepredictfunction now supports both single dates and date ranges, meaning that developers using the function will need to account for the possibility of receiving a tuple of two dates when using range mode.