ISSUE 91: Show correct Error message for invalid JSON #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow appropriate errors fix: check for err.message type before displaying to user
Comment on lines
+137
to
+140
| return { | ||
| name: decodeURIComponent(fileName), | ||
| data: JSON.parse(file.data), | ||
| }; |
There was a problem hiding this comment.
- In
bookmarksync.jsearlier we were only sending file data, and not the file name, therefore while showing error message it used to like this
The bookmarks file with name <name not defined> is not valid
- This will be get fixed now for firefox, chrome and brave browser as well
| // Github only gives url of files under a folder, so we need to extract file name from url | ||
| // example github url: https://api.github.com/repos/this-is-shivamsingh/bookmarks/contents/test_folder_3%2Fa.json | ||
| // Then full file name is after `contents` part | ||
| const fileName = url.split('contents').pop(); |
There was a problem hiding this comment.
- Tested with multiple nested folders, and it successfully extracts file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #91
Context:
Changes:
github-bookmark-loader.jsto check for following thingsto throw appropriate errors with correct filename
options.jsshow check the error.message data type before showing it on pop window to avoid[object object]error messageTesting: