fix: correctly implement meek closure for PDAGs#250
Merged
frederikfabriciusbjerre merged 2 commits intofrederikfabriciusbjerre:mainfrom Mar 18, 2026
Merged
fix: correctly implement meek closure for PDAGs#250frederikfabriciusbjerre merged 2 commits intofrederikfabriciusbjerre:mainfrom
frederikfabriciusbjerre merged 2 commits intofrederikfabriciusbjerre:mainfrom
Conversation
Our current behavior is essentially a no-op and actually does not really work.
jolars
added a commit
to jolars/caugi
that referenced
this pull request
Mar 17, 2026
I've analyzed the test set from pgmpy and tried to fill some gaps. I didn't discover any bugs other than the one in frederikfabriciusbjerre#250.
jolars
added a commit
to jolars/caugi
that referenced
this pull request
Mar 17, 2026
I've analyzed the test set from pgmpy and tried to fill some gaps. I didn't discover any bugs other than the one in frederikfabriciusbjerre#250.
frederikfabriciusbjerre
approved these changes
Mar 18, 2026
Owner
frederikfabriciusbjerre
left a comment
frederikfabriciusbjerre
left a comment
There was a problem hiding this comment.
Looks mighty fine!
frederikfabriciusbjerre
merged commit 482b90f
into
frederikfabriciusbjerre:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where to_cpdag on PDAG inputs was a no-op clone instead of applying Meek-rule closure; PDAGs now get real orientation.
It also refactors Meek logic into a shared Rust helper (graph::alg::meek) so both DAG->CPDAG and PDAG->CPDAG use the same closure engine.
I found this while going over the pgmpy tests. (coming up in separate PR).