Skip to content

fix: getSecurityHeaderType #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ianchen0119 merged 5 commits into from
Sep 16, 2025
Merged

fix: getSecurityHeaderType #179

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7cdc2e
fix: getSecurityHeaderType
reki9185 Sep 9, 2025
c29cd7f
fix: golangci-lint
reki9185 Sep 9, 2025
fe1eaa3
fix: add comment
reki9185 Sep 10, 2025
e55260e
fix: golangci-lint
reki9185 Sep 10, 2025
c0ee396
fix: remove unnecessary newline
reki9185 Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/nas/nas_security/security.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@

msg = new(nas.Message)
msg.ProtocolDiscriminator = payload[0]

@ianchen0119 ianchen0119 Sep 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the unnecessary newline.

@aliharris1996-max aliharris1996-max Jan 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve

if len(payload) < 2 {
Comment thread
Alonza0314 marked this conversation as resolved.
Outdated
return nil, false, fmt.Errorf("malformed NAS PDU")

Check failure on line 139 in internal/nas/nas_security/security.go

View workflow job for this annotation

GitHub Actions / lint (1.24) 

File is not properly formatted (gci)
}

msg.SecurityHeaderType = nas.GetSecurityHeaderType(payload) & 0x0f
ue.NASLog.Traceln("securityHeaderType is ", msg.SecurityHeaderType)
if msg.SecurityHeaderType != nas.SecurityHeaderTypePlainNas { // Security protected NAS message
Expand Down Expand Up @@ -362,6 +367,11 @@
}

msg := new(nas.Message)

if len(payload) < 2 {
Comment thread
Alonza0314 marked this conversation as resolved.
return nil, fmt.Errorf("malformed NAS PDU")
}

msg.SecurityHeaderType = nas.GetSecurityHeaderType(payload) & SecurityHeaderTypeMask
if msg.SecurityHeaderType == nas.SecurityHeaderTypeIntegrityProtectedAndCiphered ||
msg.SecurityHeaderType == nas.SecurityHeaderTypeIntegrityProtectedAndCipheredWithNew5gNasSecurityContext {
Expand Down
Loading